Skip to content

chore: Add promptTokens and completionTokens fields #5542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2024
Merged

chore: Add promptTokens and completionTokens fields #5542

merged 3 commits into from
Dec 2, 2024
+7 −0

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Dec 1, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces new fields to track token usage in the usageEventSchema of the @thirdweb-dev/service-utils package.

Detailed summary

  • Added promptTokens field as an optional integer, non-negative number.
  • Added completionTokens field as an optional integer, non-negative number.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 1, 2024 15:14 Inactive
@vercel
Copy link

vercel bot commented Dec 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 0:17am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 0:17am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 2, 2024 0:17am
wallet-ui ⬜️ Skipped (Inspect) Dec 2, 2024 0:17am

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a5768b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Dec 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (393d0cf) to head (a5768b1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5542   +/-   ##
=======================================
  Coverage   46.19%   46.19%           
=======================================
  Files        1081     1081           
  Lines       58613    58613           
  Branches     3933     3933           
=======================================
  Hits        27075    27075           
  Misses      30855    30855           
  Partials      683      683
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 46d1acf
packages 41.75% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 4.4 s (+74.22% 🔺) 5.4 s
thirdweb (cjs) 107.27 KB (0%) 2.2 s (0%) 6.7 s (-1.08% 🔽) 8.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 241 ms (+60.21% 🔺) 353 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 52 ms (+16.74% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 18.28 KB (0%) 366 ms (0%) 390 ms (-9.19% 🔽) 755 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 00:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 00:07 Inactive
@arcoraven arcoraven merged commit 8aa454c into main Dec 2, 2024
24 of 27 checks passed
@arcoraven arcoraven deleted the ph/addNebulaUsageFields branch December 2, 2024 00:07
@jnsdls jnsdls mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakeloo jakeloo jakeloo approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arcoraven @jakeloo